Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the CIS hardening steps when tar URL is used #231

Merged
merged 3 commits into from
May 24, 2024
Merged

fix the CIS hardening steps when tar URL is used #231

merged 3 commits into from
May 24, 2024

Conversation

mddamato
Copy link
Contributor

No description provided.

@mddamato mddamato requested a review from aleiner May 23, 2024 19:36
@aleiner
Copy link
Contributor

aleiner commented May 23, 2024

logic for 60-rke2-cis.conf needs to be revised to support Tarball install on RHEL. check to see which exists:
/usr/share/rke2/rke2-cis-sysctl.conf
or
/usr/local/share/rke2/rke2-cis-sysctl.conf

and copy that file.

While you're at it, the reboot logic should probably be blocked to a single node at a time.

@mddamato
Copy link
Contributor Author

I think it already does what you're asking. There is one copy
here for yum installs which comes from /usr/share/rke2/
and another
here for non-yum which come from usr/local/share/rke2/

@mddamato mddamato requested a review from aleiner May 23, 2024 21:03
@aleiner aleiner merged commit 9560581 into main May 24, 2024
5 checks passed
@aleiner aleiner deleted the fix-cis-hardening-with-tar-url branch May 24, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleiner aleiner aleiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mddamato @aleiner